trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <>
Subject [GitHub] incubator-trafodion pull request: [Trafodion-1424] Enable CIF for ...
Date Wed, 05 Aug 2015 17:01:50 GMT
Github user DaveBirdsall commented on a diff in the pull request:
    --- Diff: core/sql/generator/GenRelScan.cpp ---
    @@ -2183,6 +2182,17 @@ short HbaseAccess::codeGen(Generator * generator)
       if (getTableDesc()->getNATable()->hasAddedColumn())
         hasAddedColumns = TRUE;
    +  NABoolean alignedFormatTable = 
    +    getTableDesc()->getNATable()->isSQLMXAlignedTable();
    --- End diff --
    Will this line conflict with Selva's change? (See
I'm wondering about ths isSQLMXAlignedTable() call in particular.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message