trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <>
Subject [GitHub] incubator-trafodion pull request: [Trafodion-1433] [Trafodion-39] ...
Date Sat, 08 Aug 2015 21:58:43 GMT
Github user DaveBirdsall commented on a diff in the pull request:
    --- Diff: install/installer/tools/ambari_setup ---
    @@ -62,6 +65,9 @@ done
     #Info for log file
     sudo mkdir -p /var/log/trafodion
     sudo chmod 777 /var/log/trafodion
    +linuxInstalled=$(grep -cr SUSE /proc/version)
    --- End diff --
    I assume $linuxInstalled is the empty string if it is not SUSE? (Which seems a little
odd.) I wonder if a better name for the variable would be $SUSEInstalled?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message