trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertamarton <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Fixes for Jira's trafodion-19 & ...
Date Fri, 21 Aug 2015 21:46:36 GMT
Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/62#discussion_r37681513
  
    --- Diff: core/sql/sqlcomp/CmpSeabaseDDLmd.h ---
    @@ -238,6 +238,16 @@ static const QString seabaseObjectsUniqIdxDDL[] =
       {" ; "}
     };
     
    +enum SeabaseObjectsFlags {
    +  SEABASE_OBJECT_IS_EXTERNAL_HIVE  = 0x0000000000000001, // set if this object
    --- End diff --
    
    I generated this enum based off a similar FLAGS field for the COLUMNS table.  
    num SeabaseColumnsFlags {
      SEABASE_COLUMN_IS_SALT       = 0x0000000000000001, // don't rely on this quite yet,
                                                  
      SEABASE_COLUMN_IS_DIVISION   = 0x0000000000000002
    
    I think we should be consistent in the naming.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message