trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: fix #JIRA 1449: missing end key.
Date Thu, 27 Aug 2015 16:08:29 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/66#discussion_r38113574
  
    --- Diff: core/sql/optimizer/SimpleScanOptimizer.cpp ---
    @@ -218,25 +218,14 @@ SimpleFileScanOptimizer::isLogicalSubPartitioned() const
     SearchKey *
     SimpleFileScanOptimizer::constructSearchKey()
     {
    +  // We do not need to incude the flatten version of RANGE SPEC predicates 
    +  // to the exePreds because SearchKey is capable of handling such predicates.
    --- End diff --
    
    Good question, and it makes me think of two things. One is that the example where MDAM
can't retrieve the exact set is probably one that involves complex predicates on two or more
columns, while RangeSpec itself is probably simple enough. But RangeSpec AND <some other
predicate> might fall into this category. The second question is whether we really handle
RangeSpec predicates correctly in MDAM code generation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message