trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1453] Improvements in...
Date Thu, 27 Aug 2015 16:56:20 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/67#discussion_r38118768
  
    --- Diff: core/sql/executor/ExHdfsScan.cpp ---
    @@ -1427,24 +1424,28 @@ char * ExHdfsScanTcb::extractAndTransformAsciiSourceToSqlRow(int
&err,
           else
             attr = NULL;
      
    -      if (!isTrailingMissingColumn)
    -        sourceColEnd = strchr(sourceData, delimiter);
    -
    -      if(!isTrailingMissingColumn)
    -	{
    -          short len = 0;
    -	  if (sourceColEnd  &&
    -	      sourceColEnd <= sourceDataEnd)
    -	    len = sourceColEnd - sourceData;
    -	  else
    -            { 
    -              len = sourceDataEnd - sourceData;
    -              if (i != hdfsScanTdb().convertSkipListSize_ - 1)
    -                isTrailingMissingColumn = TRUE;
    -            }
    -
    -          if (attr) // this is a needed column. We need to convert
    -          {
    +      if (!isTrailingMissingColumn) {
    +         sourceColEnd = hdfs_strchr(sourceData, rd, cd, sourceDataEnd, &rdSeen);
    --- End diff --
    
    What about NULL? We used to treat \N as NULL before I think. Can we still do that. For
non-string columns will a missing value be treated as NULL?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message