trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1488] Master exec log...
Date Fri, 11 Sep 2015 16:08:44 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/79#discussion_r39287259
  
    --- Diff: core/sql/qmscommon/QRLogger.cpp ---
    @@ -609,7 +623,13 @@ void QRLogger::log(std::string &cat,
         {
             if ( myLevel == log4cxx::Level::getOff() )
               return;
    -        if ( myLevel->toInt() < paramLevel->toInt() )
    +
    +        int_32 configuredLevel = myLevel->toInt();
    +        int_32 requestedLevel = paramLevel->toInt();
    +  
    +        // If the configured logging level is greater (more restrictive) than
    +        // the requested level, don't log. 
    +        if ( configuredLevel > requestedLevel)
    --- End diff --
    
    Thanks for these changes. The code is easier to understand now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message