trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <>
Subject [GitHub] incubator-trafodion pull request: Jira1443 final committed
Date Mon, 21 Sep 2015 15:53:17 GMT
Github user DaveBirdsall commented on a diff in the pull request:
    --- Diff: core/sqf/sql/scripts/install_hadoop_regr_test_env ---
    @@ -214,6 +213,20 @@ fi
       cd $MY_TPCDS_DATA_DIR
    +  which iconv >>${MY_LOG_FILE} 2>&1
    +  if (( $? != 0 ))
    +  then
    +    echo "iconv utility not available. The data will be in ISO-8859-1 format."
    +  else
    +    echo "Converting the data into UTF-8 format ..."
    +    for t in date_dim time_dim item customer customer_demographics household_demographics
customer_address store promotion store_sales
    +      do
    +        iconv -f ISO-8859-1 -t UTF-8 -o ${t}.utf8.dat ${t}.dat >>${MY_LOG_FILE}
    +        mv ${t}.utf8.dat ${t}.dat
    --- End diff --
    This is not idempotent. (If we do it a second time we'll get invalid data.) If this script
is interrupted and restarted from the beginning, do we get fresh copies of all the data?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message