trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Jira1443 final committed
Date Mon, 21 Sep 2015 16:09:50 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/87#discussion_r39989803
  
    --- Diff: core/sql/ustat/hs_parser.cpp ---
    @@ -428,25 +435,22 @@ Lng32 AddTableName( const hs_table_type type
                 LM->Log(LM->msg);
              }
     
    -        const char* period = strchr(hs_globals->catSch->data(), '.');
    -        NAString catName(hs_globals->catSch->data(),
    -                         period - hs_globals->catSch->data());
    +        NAString catName(hs_globals->objDef->getCatName());
    +
    +        *hs_globals->hstogram_table = getHistogramsTableLocation(hs_globals->catSch->data(),
FALSE);
    +
    +        *hs_globals->hsintval_table = getHistogramsTableLocation(hs_globals->catSch->data(),
FALSE);
    --- End diff --
    
    Looks like hsintval_table will get the same value as hstogram_table? (At least I can't
see anything different on the right hand side of the two assigns)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message