trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nonstop-qfchen <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Jira1443 final committed
Date Mon, 21 Sep 2015 16:20:28 GMT
Github user nonstop-qfchen commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/87#discussion_r39991101
  
    --- Diff: core/sql/ustat/hs_yacc.y ---
    @@ -60,6 +60,8 @@ extern THREAD_P HSGlobalsClass *hs_globals_y;
     extern int yylex(YYSTYPE * lvalp, void* scanner);
     //extern int yylex();
     
    +extern NABoolean isUpdatestatsStmt;
    --- End diff --
    
    Good point. I'll move it to hs_globals.
    
    On Mon, Sep 21, 2015 at 11:11 AM, DaveBirdsall <notifications@github.com>
    wrote:
    
    > In core/sql/ustat/hs_yacc.y
    > <https://github.com/apache/incubator-trafodion/pull/87#discussion_r39990031>
    > :
    >
    > > @@ -60,6 +60,8 @@ extern THREAD_P HSGlobalsClass *hs_globals_y;
    > >  extern int yylex(YYSTYPE * lvalp, void* scanner);
    > >  //extern int yylex();
    > >
    > > +extern NABoolean isUpdatestatsStmt;
    >
    > There's no object we can stick this global inside of?
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/incubator-trafodion/pull/87/files#r39990031>.
    >
    
    
    
    -- 
    Regards, --Qifan



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message