trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nonstop-qfchen <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Jira1443 final committed
Date Mon, 21 Sep 2015 19:01:36 GMT
Github user nonstop-qfchen commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/87#discussion_r40011275
  
    --- Diff: core/sql/optimizer/ObjectNames.cpp ---
    @@ -1385,6 +1386,17 @@ void QualifiedName::print(FILE* ofd, const char* indent, const
char* title) cons
     #endif
     }
     
    +NABoolean QualifiedName::isHistograms() const
    +{
    +   return (getObjectName() == "SB_HISTOGRAMS");
    +}
    +
    +NABoolean QualifiedName::isHistogramIntervals() const
    +{
    +   return (getObjectName() == "SB_HISTOGRAM_INTERVALS");
    +}
    --- End diff --
    
    changed.
    
    On Mon, Sep 21, 2015 at 1:11 PM, Roberta Marton <notifications@github.com>
    wrote:
    
    > In core/sql/optimizer/ObjectNames.cpp
    > <https://github.com/apache/incubator-trafodion/pull/87#discussion_r40004717>
    > :
    >
    > > @@ -1385,6 +1386,17 @@ void QualifiedName::print(FILE* ofd, const char* indent,
const char* title) cons
    > >  #endif
    > >  }
    > >
    > > +NABoolean QualifiedName::isHistograms() const
    > > +{
    > > +   return (getObjectName() == "SB_HISTOGRAMS");
    > > +}
    > > +
    > > +NABoolean QualifiedName::isHistogramIntervals() const
    > > +{
    > > +   return (getObjectName() == "SB_HISTOGRAM_INTERVALS");
    > > +}
    >
    > Might want to use the predefined values found in ComSmallDefs.h -
    > HBASE_HIST_NAME & HBASE_HISTINT_NAME
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/incubator-trafodion/pull/87/files#r40004717>.
    >
    
    
    
    -- 
    Regards, --Qifan



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message