trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1497] Fix expected re...
Date Fri, 25 Sep 2015 00:19:37 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/91#discussion_r40389240
  
    --- Diff: core/sql/regress/compGeneral/EXPECTED042 ---
    @@ -1977,25 +1977,31 @@ NUM_HITS    NUM_PARAMS
     ----------  ----------
     
              0           1
    +         0           1
    +         0           1
    +         0           1
    +         0           2
              0           2
    +         0           2
    +         0           2
    +         0           3
              0           3
    +         0           4
              0           5
              1           1
              1           1
              1           2
              1           2
              1           3
    +         1           3
    --- End diff --
    
    Same number of queries as before. What's happening is that some of the cache entries are
not matching up due to differences in CQDs. That's not surprising as the bug in 1494 prevented
the toggling of CQDs in some circumstances. In this particular test suite, the metadata queries
get cached very early on and the increase in cache usage stops. (I found this out by peppering
a copy of the test script with selects against querycache.) So it is up-front growth. Of course
if we wish, we could investigate further and perhaps add or delete some of the CQDs in the
metadata code to improve the entry sharing. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message