trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: resolve JIRA-1495
Date Mon, 28 Sep 2015 16:03:59 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/94#discussion_r40570077
  
    --- Diff: core/sql/sqlcomp/nadefaults.cpp ---
    @@ -3522,8 +3522,10 @@ XDDkwd__(SUBQUERY_UNNESTING,			"ON"),
      XDDui___(USTAT_MAX_READ_AGE_IN_MIN,            "5760"),
       DDui___(USTAT_MAX_SAMPLE_AGE,                 "365"),  // For R2.5 set to a year so
user created samples won't be removed.
     
    +  DDflt0_(USTAT_MIN_CHAR_DATASIZE_FOR_IS,      "1000"),  // max data size in MB for char
type to use 
    +                                                         // internal sort without checking
UEC.
    --- End diff --
    
    Why does the name of the default talk of "MIN", but the comment talks of "max"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message