trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1858] RI predicate ge...
Date Tue, 01 Mar 2016 00:58:42 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/347#discussion_r54507489
  
    --- Diff: core/sql/optimizer/BindRI.cpp ---
    @@ -408,6 +408,39 @@ void RefConstraint::getMatchOptionPredicateText(NAString &text,
       text += ")";
     }
     
    +//helper function to check if the given column name is reserved hidden coloum
    +static NABoolean isHiddenColumn(const char *colname)
    +{
    +  int len = strlen(colname);
    +  if(strcmp(colname , "_SALT_") ==0) 
    +    return TRUE;
    +  //check for DIVISION column
    +  //pattern _DIVISION_%d_
    +  //must longer than 12
    +  if(len >= 12) {
    +    //must end with _
    +    if(colname[len] == '_')
    --- End diff --
    
    Second Dave's comment. I suppose a column with name DIVISION_1_ will still show the problem?
Maybe adding a regression test also a good idea though certainly not a requirement.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message