trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1850] First N operato...
Date Tue, 01 Mar 2016 01:04:32 GMT
Github user DaveBirdsall commented on a diff in the pull request:
    --- Diff: core/sql/executor/ExFirstN.cpp ---
    @@ -228,11 +232,11 @@ short ExFirstNTcb::work()
     		// GET_N request value and firstNRows_ to my child.
     		if ((pentry_down->downState.request != ex_queue::GET_N) ||
     		    (pentry_down->downState.requestValue == firstnTdb().firstNRows()))
    -		  centry->downState.requestValue = firstNVal;
    +		  centry->downState.requestValue = effectiveFirstN_;
    --- End diff --
    In the comment above this (line 230 to be precise) should we change "firstNRows_" to "effectiveFirstN_"?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message