trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1850] First N operato...
Date Tue, 01 Mar 2016 02:11:48 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/351#discussion_r54513625
  
    --- Diff: core/sql/executor/ExFirstN.cpp ---
    @@ -228,11 +232,11 @@ short ExFirstNTcb::work()
     		// GET_N request value and firstNRows_ to my child.
     		if ((pentry_down->downState.request != ex_queue::GET_N) ||
     		    (pentry_down->downState.requestValue == firstnTdb().firstNRows()))
    -		  centry->downState.requestValue = firstNVal;
    +		  centry->downState.requestValue = effectiveFirstN_;
    --- End diff --
    
    Actually, that made me realize that on new line 234 the code also needs to be changed
to effectiveFirstN_.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message