trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertamarton <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: TRAFODION-1856: Revoke - object ...
Date Tue, 01 Mar 2016 17:35:17 GMT
Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/349#discussion_r54603261
  
    --- Diff: core/sql/sqlcomp/PrivMgrMD.h ---
    @@ -110,12 +106,35 @@ typedef struct {
     
     } ViewUsage;
     
    -typedef struct {
    +// -----------------------------------------------------------------------
    +// Class definitions
    +// -----------------------------------------------------------------------
    +class ObjectReference
    +{
    +  public:
    +
    +  ObjectReference()
    +  : objectUID(0),
    +    objectOwner(NA_UserIdDefault),
    +    objectType(COM_UNKNOWN_OBJECT),
    +    columnReferences(NULL),
    +    updatedPrivs()
    +  {}
    +    
    +  virtual ~ObjectReference ( void )
    +  {
    +    while(!columnReferences->empty())
    +      delete columnReferences->back(), columnReferences->pop_back();
    --- End diff --
    
    I did look this up, and it should be equivalent in this case,  the comma does not end
the statement. It is part of a longer statement which ends with a semi-colon. It does the
same thing as calling functions as separate statements.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message