trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: JIRA TRAFODION-1798 (ddl xns) an...
Date Tue, 01 Mar 2016 22:40:59 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/346#discussion_r54648838
  
    --- Diff: core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/client/transactional/TransactionalScanner.java
---
    @@ -171,19 +171,21 @@ protected boolean nextScanner(final boolean done) throws IOException{
                     return false;
                 }
                 else
    -                this.currentBeginKey = TransactionManager.binaryIncrementPos(this.currentEndKey,1);
    +                //this.currentBeginKey = TransactionManager.binaryIncrementPos(this.currentEndKey,1);
    +                  this.currentBeginKey = this.currentEndKey;
             }
             else {
                 // First call to nextScanner
                 this.currentBeginKey = this.scan.getStartRow();
             }
     
    -        this.currentRegion = ttable.getRegionLocation(this.currentBeginKey).getRegionInfo();
    +        this.currentRegion = ttable.getRegionLocation(this.currentBeginKey, false).getRegionInfo();
             this.currentEndKey = this.currentRegion.getEndKey();
     
    -        if(LOG.isTraceEnabled()) LOG.trace("Region Info: " + currentRegion.getRegionNameAsString());
    -        if(this.currentEndKey != HConstants.EMPTY_END_ROW)
    -            this.currentEndKey = TransactionManager.binaryIncrementPos(currentRegion.getEndKey(),
-1);
    +        if(LOG.isTraceEnabled()) LOG.trace("nextScanner() txID: " + ts.getTransactionId()
+ " Region Info: " + currentRegion.getRegionNameAsString()+ 
    +                         "currentBeginKey: " + Hex.encodeHexString(this.currentBeginKey)
+ "currentEndKey: " + Hex.encodeHexString(this.currentEndKey));
    +        //if(this.currentEndKey != HConstants.EMPTY_END_ROW)
    --- End diff --
    
    Consider removing the commented out lines


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message