trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: JIRA TRAFODION-1798 (ddl xns) an...
Date Tue, 01 Mar 2016 23:08:43 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/346#discussion_r54652316
  
    --- Diff: core/sql/executor/ex_transaction.cpp ---
    @@ -1316,11 +1309,29 @@ short ExTransTcb::work()
               // create a diagsArea and return it to the parent.
               handleErrors(pentry_down, ta->getDiagsArea());
     
    +        if (cliGlobals->currContext()->ddlStmtsExecuted())
    +          {
    +            ComDiagsArea * diagsArea = NULL;
    +            ExSqlComp::ReturnStatus cmpStatus = 
    +              cliGlobals->currContext()->sendXnMsgToArkcmp
    +              (NULL, 0,
    +               EXSQLCOMP::DDL_NATABLE_INVALIDATE,
    +               diagsArea);
    +            if (cmpStatus == ExSqlComp::ERROR)
    +              {
    +                handleErrors(pentry_down, NULL, 
    +                             (ExeErrorCode)(-EXE_CANT_COMMIT_OR_ROLLBACK));
    + 
    +                return -1;
    +              }
    +          }
    +        
    +        cliGlobals->currContext()->ddlStmtsExecuted() = FALSE;
    --- End diff --
    
    The ddlStmtsExecuted flag will be set to TRUE if there is any error on commit or rollback.
How can the user process recover from this,


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message