trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: JIRA TRAFODION-1798 (ddl xns) an...
Date Wed, 02 Mar 2016 00:35:15 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/346#discussion_r54661719
  
    --- Diff: core/sql/sqlcomp/CmpSeabaseDDLcleanup.cpp ---
    @@ -1089,7 +1092,7 @@ short CmpSeabaseMDcleanup::cleanupOrphanObjectsEntries(ExeCliInterface
*cliInter
       NABoolean errorSeen = FALSE;
     
       // find out all entries which do not have corresponsing hbase objects
    -  str_sprintf(query, "select object_uid, trim(catalog_name) || '.'  || trim(schema_name)
|| '.' || trim(object_name)  from %s.\"%s\".%s where catalog_name = '%s' and schema_name not
in ( '_MD_', '_REPOS_', 'PRIVMGR_MD') and (object_type = 'BT' or object_type = 'IX') ",
    +  str_sprintf(query, "select object_uid, trim(catalog_name) || '.'  || trim(schema_name)
|| '.' || trim(object_name)  from %s.\"%s\".%s where catalog_name = '%s' and schema_name not
in ( '_MD_', '_REPOS_', '_PRIVMGR_MD_') and schema_name not like '|_HV|_%%' escape '|'  and
schema_name not like '|_HB|_%%' escape '|' and (object_type = 'BT' or object_type = 'IX')
",
    --- End diff --
    
    Are schema names beginning with _HV and _HB reserved? If not, then this statement might
mistakenly filter out user schemas (like "_HVAC").


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message