trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: TRAFODION-1706
Date Thu, 03 Mar 2016 00:18:51 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/348#discussion_r54816839
  
    --- Diff: core/sqf/hbase_utilities/src/main/java/org/trafodion/utility/backuprestore/TrafExportSnapshot.java
---
    @@ -114,7 +119,10 @@
       private static final String INPUT_FOLDER_PREFIX = "export-files.";
     
       // Export Map-Reduce Counters, to keep track of the progress
    -  public enum Counter { MISSING_FILES, COPY_FAILED, BYTES_EXPECTED, BYTES_COPIED, FILES_COPIED
};
    +  public enum Counter {
    --- End diff --
    
    Should this use some enum imported from another class? org.apache.hadoop.hbase.snapshot.ExportSnapshot.Counter?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message