trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: TRAFODION-1706
Date Thu, 03 Mar 2016 00:31:34 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/348#discussion_r54818214
  
    --- Diff: core/sqf/sql/scripts/install_local_hadoop ---
    @@ -391,7 +391,19 @@ else
         MY_START_PORT=`expr 24000 + $MY_START_PORT '*' 200`
       elif [ $MY_START_PORT == "rand" ]; then
         # pick a random number between 12000 and 24000 that is divisible by 200
    -    MY_START_PORT=`expr $RANDOM '%' 60 '*' 200 + 12000`
    +    lv_number=0   #initialize
    --- End diff --
    
    Sorry, I don't quite understand the reason for this change. Isn't the new code doing what
the old code did, just more complicated? Also, it extends the range up to 31200. We wanted
to keep the range fro 24000 to 32000 reserved for installations that use the -p fromDisplay
option. Please don't change this algorithm unless there is a very good reason for doing so.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message