trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <>
Subject [GitHub] incubator-trafodion pull request: TRAFODION-1706
Date Fri, 04 Mar 2016 18:37:14 GMT
Github user selvaganesang commented on a diff in the pull request:
    --- Diff: core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/regionserver/transactional/
    @@ -77,96 +94,29 @@
      * Holds the state of a transaction. This includes a buffer of all writes, a record of
all reads / scans, and
      * information about which other transactions we need to check against.
    -public class TrxTransactionState  extends TransactionState{
    -    static boolean sb_sqm_98_1 = false;
    -    static boolean sb_sqm_98_4 = false;
    -    static boolean sb_sqm_98_9 = false;
    -    static java.lang.reflect.Constructor c98_1 = null;
    -    static java.lang.reflect.Constructor c98_4 = null;
    -    static java.lang.reflect.Constructor c98_9 = null;
    +public class TrxTransactionState extends TransactionState {
    -    static Class keepDeletedCellsClazz = null;
    -    static Class scaninfoClazz = null;
    -    static Constructor scaninfoConstructor = null;
    -    static Object[] scaninfoArgs = null;
    +    static java.lang.reflect.Constructor c1_0 = null;
         static {
             String version = VersionInfo.getVersion();// the hbase version string, eg. "0.6.3-dev"
   "Got info of Class ScanQueryMatcher for HBase version :" + version);
    --- End diff --
    I am not sure if we would maintain two different Trafodion versions and provide updates
on continuous basis. It is not clear to me who should make this call. Trafodion community?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message