trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1863] PR340 caused Pu...
Date Mon, 07 Mar 2016 18:20:34 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/364#discussion_r55246253
  
    --- Diff: core/sql/optimizer/ValueDesc.cpp ---
    @@ -529,14 +529,13 @@ NABoolean ValueId::isAddedColumnWithNonNullDefault() const{
       default:
           break;
       }
    -  if (nac && nac->isAddedColumn() && nac->getDefaultValue())
    +  if (nac &&  nac->getDefaultValue() && strcmp(nac->getDefaultValue(),"NULL")
!= 0)
    --- End diff --
    
    Will it be better to check for DefaultColumnClass == COM_NULL_DEFAULT instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message