trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mkby <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: TRAFODION-1706
Date Tue, 08 Mar 2016 16:28:21 GMT
Github user mkby commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/367#discussion_r55384539
  
    --- Diff: core/sqf/sqenvcom.sh ---
    @@ -140,18 +139,41 @@ fi
     export MY_SQROOT=$PWD
     export SQ_HOME=$PWD
     
    +# set common version to be consistent between shared lib and maven dependencies
    +export HBASE_DEP_VER_CDH=1.0.0-cdh5.4.4
    +export HIVE_DEP_VER_CDH=1.1.0-cdh5.4.4
    +export HBASE_DEP_VER_HDP=1.1.2.2.3.2.0-2950
    +export HIVE_DEP_VER_HDP=1.2.1.2.3.2.0-2950
    +export HBASE_DEP_VER_APACHE=1.0.2
    +export HIVE_DEP_VER_APACHE=1.1.0
    +export THRIFT_DEP_VER=0.9.0
    +export HBASE_TRX_ID_CDH=hbase-trx-cdh5_4
    +export HBASE_TRX_ID_APACHE=hbase-trx-apache1_0_2
    +export HBASE_TRX_ID_HDP=hbase-trx-hdp2_3
    +
     # general Hadoop & TRX dependencies - not distro specific, choose one to build against
     export HBASE_TRXDIR=$MY_SQROOT/export/lib
    -export HBASE_TRX_ID=hbase-trx-cdh5_3
    -export HBASE_DEP_VER=0.98.6-cdh5.3.0
    -export HBASE_TRX_JAR=${HBASE_TRX_ID}-${TRAFODION_VER}.jar
    -export UTIL_JAR=trafodion-utility-${TRAFODION_VER}.jar
    -if [[ "$SQ_HBASE_DISTRO" = "HDP" ]]; then
    -    export HBASE_TRX_JAR=hbase-trx-hdp2_2-${TRAFODION_VER}.jar
    +export HBASE_TRX_JAR=${HBASE_TRX_ID_CDH}-${TRAFODION_VER}.jar
    +if [[ "$HBASE_DISTRO" = "HDP" ]]; then
    +    export HBASE_TRX_JAR=${HBASE_TRX_ID_HDP}-${TRAFODION_VER}.jar
     fi
    -# set common version to be consistent between shared lib and maven dependencies
    -export THRIFT_DEP_VER=0.9.0
    -export HIVE_DEP_VER=0.13.1
    +if [[ "$HBASE_DISTRO" = "APACHE" ]]; then
    +    export HBASE_TRX_JAR=${HBASE_TRX_ID_APACHE}-${TRAFODION_VER}.jar
    --- End diff --
    
    If using Apache Hadoop, the script will detect the system as an Apache Hadoop environment,
so it will jump to line 487, and check line 618, the script will ``export HBASE_TRX_JAR=hbase-trx-hbase_98_4-${TRAFODION_VER}.jar``,
will this overwrite the ``HBASE_TRX_JAR`` you set here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message