trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandhyasun <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Support for doing GC on LOB data...
Date Tue, 08 Mar 2016 20:02:06 GMT
Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/363#discussion_r55418461
  
    --- Diff: core/sql/cli/Cli.cpp ---
    @@ -9684,15 +9640,17 @@ Lng32 SQLCLI_LOBcliInterface
     	cliRC = cliInterface->executeImmediate(query);
     
     	currContext.resetSqlParserFlags(0x1);
    -
    +	
     	if (cliRC < 0)
     	  {
     	    cliInterface->retrieveSQLDiagnostics(myDiags);
    -	    
    +	    if (myDiags->containsError(-CAT_OBJECT_DOES_NOT_EXIST_IN_TRAFODION))
    --- End diff --
    
    We will ignore only this particular  error. If it's any other error, we go to "error_return".
That will return an error to the calling layer. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message