trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandhyasun <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Support for doing GC on LOB data...
Date Tue, 08 Mar 2016 20:03:17 GMT
Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/363#discussion_r55418597
  
    --- Diff: core/sql/cli/Cli.cpp ---
    @@ -9581,15 +9531,14 @@ Lng32 SQLCLI_LOBcliInterface
     
     	if (cliRC < 0)
     	  {
    -	    cliInterface->executeImmediate("cqd pos restore;");
    -
    +	    
     	    cliInterface->retrieveSQLDiagnostics(myDiags);
     	    
     	    goto error_return;
     	  }
     
                	// create lob descriptor chunks table salted
    -       	str_sprintf(query, "create ghost table %s (descPartnKey largeint not null, descSysKey
largeint not null, chunkNum int not null, chunkLen largeint not null, intParam largeint, stringParam
varchar(400), primary key(descPartnKey, descSysKey, chunkNum)) salt using 8 partitions",
    +       	str_sprintf(query, "create ghost table %s (descPartnKey largeint not null, descSysKey
largeint not null, chunkNum int not null, chunkLen largeint not null, dataOffset largeint,
stringParam varchar(400), primary key(descPartnKey, descSysKey, chunkNum)) salt using 8 partitions",
     	lobDescChunksName); 
    --- End diff --
    
    Yes normally it will. It is safe to make this change now since the feature is not officially
"externalized". 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message