trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: TRAFODION [1879] - Integrate Lib...
Date Tue, 08 Mar 2016 23:42:33 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/372#discussion_r55449227
  
    --- Diff: core/sql/common/ComUser.cpp ---
    @@ -347,3 +347,57 @@ Int16 ComUser::getAuthNameFromAuthID(Int32   authID,
     
       return FEOK;
     }
    +
    +// ----------------------------------------------------------------------------
    +// method: getRoleList
    +//
    +// Returns the list of system roles
    +// Params:
    +//   (out) roleList - the list of roles, space is managed by the caller
    +//   (out) actualLen - the length of the returned role list
    +//   ( in) maxLen - the size of the roleList allocated by the caller
    +//   ( in) delimited - delimiter to use (defaults to single quote)
    +//   ( in) separator - specified what separator to use (defaults to comma)
    +//   ( in) includeSpecialAuths - includes the special auths (PUBLIC and _SYSTEM) 
    +//
    +//  Returns:  FEOK -- found
    +//            FEBUFTOOSMALL -- space allocated for role list is too small 
    +// ----------------------------------------------------------------------------
    +Int32 ComUser::getRoleList (char * roleList,
    --- End diff --
    
    I wonder if we could return an NAString instead, then we'd never have to trouble ourselves
with FEBUFTOOSMALL? (At the price of dynamic heap management though.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message