trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1880] Do not build li...
Date Wed, 09 Mar 2016 00:03:09 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/373#discussion_r55451610
  
    --- Diff: core/sqf/sql/scripts/get_libhdfs_files ---
    @@ -110,113 +123,141 @@ if [[ $FORCE_BUILD == true || \
           exit 1
         fi
       fi
    -
       cd $LIBHDFS_TEMP_DIR
     
    -  PROTOBUF_VER=`protoc --version 2>/dev/null | cut -f 2 -d ' '`
    +  if [[ $SOURCE_BUILD != true ]]; then
    +    echo "Downloading Hadoop-common binary distro..." | tee -a ${LOGFILE}
    +    wget ${HADOOP_MIRROR_URL}/${HADOOP_BIN_TAR} 2>&1 >>${LOGFILE}
    +    tar -xzf $HADOOP_BIN_TAR  \
    +       $HADOOP_ID/lib/native/libhadoop\*so\* \
    +       $HADOOP_ID/lib/native/libhdfs\*so\* \
    +       $HADOOP_ID/include/hdfs.h
    +
    +    cp -f ${HADOOP_ID}/include/hdfs.h ${TGT_INC_DIR}
    +    cp -Pf ${HADOOP_ID}/lib/native/libhdfs*.so* ${TGT_LIB_DIR}
    +    cp -Pf ${HADOOP_ID}/lib/native/libhadoop*.so* ${TGT_LIB_DIR}
    +
    +  else
    +
    +    PROTOBUF_VER=`protoc --version 2>/dev/null | cut -f 2 -d ' '`
    --- End diff --
    
    Those are all marked as new, but my guess is that they are just indented, so I didn't
look at these lines in detail.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message