trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traflm <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1886] Region Server f...
Date Fri, 11 Mar 2016 15:37:39 GMT
Github user traflm commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/376#discussion_r55844614
  
    --- Diff: core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/coprocessor/transactional/SplitBalanceHelper.java
---
    @@ -304,11 +304,13 @@ protected void zkCleanup() {
               List<String> trafTables = ZKUtil.listChildrenNoWatch(zkw, zSplitBalPathNoSlash);
               List<String> hbaseTables = ZKUtil.listChildrenNoWatch(zkw, SplitBalanceHelper.zkTable);
               
    -          for(String tableName : trafTables) {
    +          if(trafTables != null && hbaseTables != null) {
    --- End diff --
    
    There is a possibility that trafTables is not null but hbaseTables is null, or vice versa.
In this case, the cleanup will leave something.
    I am not quite clear, but I think this method is to clean up every leftover znodes. So
the '&&' may not be proper here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message