trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: JIRA 1849 Add support for alter ...
Date Mon, 14 Mar 2016 16:17:38 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/381#discussion_r56027243
  
    --- Diff: core/sql/common/NAString.cpp ---
    @@ -280,6 +280,29 @@ NAString Int64ToNAString(Int64 l)
       return NAString(resultstr);
     }
     
    +NAString &replaceAll(NAString &source, const NAString &searchFor,
    +                     const NAString &replaceWith)
    +{
    +  size_t indexOfReplace = NA_NPOS;
    +  indexOfReplace = source.index(searchFor);
    +  if (indexOfReplace != NA_NPOS)
    --- End diff --
    
    The "if" is unnecessary. If you delete it, the code behaves exactly as it would have otherwise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message