trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: TRAFODION-1885 : online expansio...
Date Wed, 16 Mar 2016 19:24:33 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/385#discussion_r56398777
  
    --- Diff: core/sqf/monitor/linux/pnode.cxx ---
    @@ -1528,6 +1528,14 @@ void CNodeContainer::AddNodes( )
         int pnid;
         int rank;
         int *sparePNids = NULL;
    +    
    +    //  only relevant on a workstation acting as a single node
    +    const char* envVar = getenv("SQ_MAX_RANK"); 
    +    int maxNode;
    +    if (envVar != NULL)
    +      maxNode = atoi (envVar);
    --- End diff --
    
    Again, I suppose SQ_MAX_RANK is a debugging tool, so we don't bother checking for non-numeric
inputs such as might happen with "export SQ_MAX_RANK=ON" (where atoi would return 0 I think).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message