trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anoopsharma00 <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: JIRA 1849 Add support for alter ...
Date Wed, 16 Mar 2016 20:54:34 GMT
Github user anoopsharma00 commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/381#discussion_r56413042
  
    --- Diff: core/sql/common/NAString.cpp ---
    @@ -280,6 +280,29 @@ NAString Int64ToNAString(Int64 l)
       return NAString(resultstr);
     }
     
    +NAString &replaceAll(NAString &source, const NAString &searchFor,
    +                     const NAString &replaceWith)
    +{
    +  size_t indexOfReplace = NA_NPOS;
    +  indexOfReplace = source.index(searchFor);
    +  if (indexOfReplace != NA_NPOS)
    --- End diff --
    
    yes, that is true. 
    This method was moved from sqlcomp/CmpDescribe.cpp to common dir
    and is not new code.
    Will fix it in a later checkin.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message