trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: JIRA TRAFODION-1901 Default clau...
Date Mon, 21 Mar 2016 17:00:33 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/398#discussion_r56858053
  
    --- Diff: core/sql/parser/sqlparser.y ---
    @@ -25040,14 +25036,6 @@ column_definition : qualified_name
     column_name : identifier
     
     /* type pElemDDL */
    -optional_col_def_default_clause : empty
    -                                {
    -                                  $$ = NULL;
    -                                }
    -
    -                      | col_def_default_clause
    -
    -/* type pElemDDL */
     col_def_default_clause : TOK_DEFAULT enableCharsetInferenceInColDefaultVal col_def_default_clause_argument
    --- End diff --
    
    Our parser actually got smaller!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message