trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eowhadi <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1900] Optimize MDAM s...
Date Mon, 21 Mar 2016 17:04:05 GMT
Github user eowhadi commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/395#discussion_r56858635
  
    --- Diff: core/sql/executor/ExHbaseSelect.cpp ---
    @@ -444,6 +444,7 @@ ExWorkProcRetcode ExHbaseScanSQTaskTcb::work(short &rc)
       Lng32 retcode = 0;
       rc = 0;
       Lng32 remainingInBatch = batchSize_;
    +  NABoolean isFirstBatch = false;
    --- End diff --
    
    I think you are right , I thought the only exit would be due to batch size exceeding,
and was seeing batch size =*K, so was good. But now I see  	    if (tcb_->moveRowToUpQueue(tcb_->convertRow_,
tcb_->convertRowLen_, 
     				       &rc, FALSE))		 				       &rc, FALSE))
     	      return 1;		 	      return 1;
    
    I am guessing this is what you are talking about (parent queue fill up). Can this happen
realistically before the first 8K?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message