trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1900] Optimize MDAM s...
Date Mon, 21 Mar 2016 17:10:24 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/395#discussion_r56859815
  
    --- Diff: core/sql/executor/ExHbaseSelect.cpp ---
    @@ -444,6 +444,7 @@ ExWorkProcRetcode ExHbaseScanSQTaskTcb::work(short &rc)
       Lng32 retcode = 0;
       rc = 0;
       Lng32 remainingInBatch = batchSize_;
    +  NABoolean isFirstBatch = false;
    --- End diff --
    
    It depends on the queue size. Which is set by the compiler and can be modified by the
executor. But just as a general design principle, work methods are designed to interrupt their
work at any time (often due to some resource constraint) so it is best to use members for
any state that is needed for the life of the operator.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message