trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amandamoran <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [[TRAFODION 1903 ]] Removing TRA...
Date Wed, 23 Mar 2016 22:12:52 GMT
Github user amandamoran commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/399#discussion_r57246433
  
    --- Diff: install/installer/rest_installer ---
    @@ -108,13 +108,6 @@ mv $MY_SQROOT/sqenvcom.temp $MY_SQROOT/sqenvcom.sh
     cd $REST_DIR/conf
     
     echo "***INFO: modifying $REST_DIR/conf/rest-site.xml"
    -# get zookeeper quorum
    -
    -lineNumber=$(grep -n "zookeeper\.quorum" /etc/hbase/conf/hbase-site.xml | sed 's/\:.*//')
    -lineNumber=$((lineNumber+1))
    -
    -ZOOKEEPER_NODES=`sed "$lineNumber!d" /etc/hbase/conf/hbase-site.xml | sed 's/\/value.*//'
| sed 's/.*>//' | sed 's/.$//'`
    -
     # add zookeeper quorum property to end of configuration
     rm rest-site.temp 2>/dev/null
     cat rest-site.xml | sed -e "s@</configuration>@  <property>\n    <name>rest.zookeeper.quorum</name>\n
   <value>$ZOOKEEPER_NODES</value>\n  </property>\n </configuration>@"
> rest-site.temp
    --- End diff --
    
    Added this! Thanks! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message