trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: TRAFODION-1910 mxosrvr crashes o...
Date Wed, 30 Mar 2016 15:25:58 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/405#discussion_r57908077
  
    --- Diff: core/sql/cli/CliExtern.cpp ---
    @@ -6316,7 +6316,8 @@ Lng32 SQL_EXEC_DeleteHbaseJNI()
           threadContext->incrNumOfCliCalls();
     
           HBaseClient_JNI::deleteInstance();
    -      HiveClient_JNI::deleteInstance();
    +      // The Hive client persists across connections
    +      // HiveClient_JNI::deleteInstance();
    --- End diff --
    
    Whenever a context is dropped, both hbaseClient_JNI and hiveClient_JNI is getting deleted.
This CLI call is being called from the two places shown below. I am not sure about the need
for this calls in these functions. If it is needed, I would think there would be similar problem
with HBaseClient_JNI::deleteInstance too. Or is it better to get rid of this CLI call.
    
    arkcmp/CmpStatement.cpp:  SQL_EXEC_DeleteHbaseJNI();
    sqlcomp/CmpSeabaseDDLcommon.cpp:  SQL_EXEC_DeleteHbaseJNI();
    
    In case of mxosrvr, there is default context. In case of T2 driver, the CliContext would
be deallocated and these objects would be deleted. I am assuming that it should be ok to do
that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message