trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: TRAFODION-1910 mxosrvr crashes o...
Date Wed, 30 Mar 2016 17:56:58 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/405#discussion_r57933613
  
    --- Diff: core/sql/cli/CliExtern.cpp ---
    @@ -6316,7 +6316,8 @@ Lng32 SQL_EXEC_DeleteHbaseJNI()
           threadContext->incrNumOfCliCalls();
     
           HBaseClient_JNI::deleteInstance();
    -      HiveClient_JNI::deleteInstance();
    +      // The Hive client persists across connections
    +      // HiveClient_JNI::deleteInstance();
    --- End diff --
    
    I would echo Selva's comment. Can you please explain how the HiveClient_JNI object is
different from HBaseClient_JNI? I had tried to model HiveClient_JNI after HBaseClient_JNI
and would like check if that assumption is incorrect in other places too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message