trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From svarnau <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1880] Do not build li...
Date Tue, 08 Mar 2016 23:52:47 GMT
GitHub user svarnau opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/373

    [TRAFODION-1880] Do not build libhdfs dependency from source

    Make sure various pom.xml files with hadoop dependency are all pulling in
    the same version.
    
    Make HDFS dependencies a build-time pre-req. As with other build
    dependencies on shared libraries, make them part of the build environment
    (TOOLSDIR).
    
    Prior to this change, we were picking up these dependencies (2 shlib &
    1 header) from environment (such as local_hadoop) or downloading the
    source and building it on the fly. Building it made trafodion build more
    than twice as long.
    
    Now requiring a consistent build dependency, separate from the runtime
    environment.
    
    The 64-bit native libraries are now available from binary distro of
    hadoop-common. So we can download binaries and extract files we need rather
    than build them.  Dependencies can be updated via install/traf_tools_setup.sh,
    but in case the environment is not updated, the build-time script get_hdfs_files
    is also updated to downoad the distro. If you really want to build
    hadoop-common, that portion of the script was retained under a new --source
    option.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/svarnau/incubator-trafodion libs1880

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/373.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #373
    
----
commit 3853382a5d5386f1b048f2c1bdb4eea0440b4a16
Author: Steve Varnau <svarnau@apache.org>
Date:   2016-03-08T23:26:48Z

    [TRAFODION-1880] Do not build libhdfs dependency from source
    
    Make sure various pom.xml files with hadoop dependency are all pulling in
    the same version.
    
    Make HDFS dependencies a build-time pre-req. As with other build
    dependencies on shared libraries, make them part of the build environment
    (TOOLSDIR).
    
    Prior to this change, we were picking up these dependencies (2 shlib &
    1 header) from environment (such as local_hadoop) or downloading the
    source and building it on the fly. Building it made trafodion build more
    than twice as long.
    
    Now requiring a consistent build dependency, separate from the runtime
    environment.
    
    The 64-bit native libraries are now available from binary distro of
    hadoop-common. So we can download binaries and extract files we need rather
    than build them.  Dependencies can be updated via install/traf_tools_setup.sh,
    but in case the environment is not updated, the build-time script get_hdfs_files
    is also updated to downoad the distro. If you really want to build
    hadoop-common, that portion of the script was retained under a new --source
    option.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message