trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traflm <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1868] Compatibility w...
Date Thu, 10 Mar 2016 02:35:42 GMT
GitHub user traflm opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/374

    [TRAFODION-1868] Compatibility with gcc 4.8

    this is partial changes to Trafodion code base in order to make it compatible with gcc
4.8.
    Gcc 4.8 generally is more strict than gcc 4.4, so Trafodion code need to fix all potential
issues.
    1. variable declared and initialized, but not used anymore
    2. suspicious overload of same variable names
    3. ld need the required library name to be explicitly added using '-l' option
    4. some STL/Boost functions replaced with c++11 features in gcc 4.8, so remove unnecessary
call into boost
    So there are a lot of changes, to make this process easier, we decided to do this incrementally.
Fix small amount of issues each time, easier to code review and test.
    It must make sure same code compile and work well under gcc 4.4.
    
    This is the first commit for the whole gcc 4.8 support changes.
    We already have a successful gcc 4.8 build prototype, and it works well on CentOS 7. But
there are still more changes, so this is a rather proven way to support gcc 4.8.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/traflm/incubator-trafodion TRAFODION-1854

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #374
    
----
commit 1ec16451e37fa21e3978a88def5188a6ff22900c
Author: Liu Ming <ming.liu@esgyn.cn>
Date:   2016-03-10T02:26:07Z

    [TRAFODION-1868] Compatibility with gcc 4.8

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message