trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: TRAFODION-1706
Date Mon, 18 Apr 2016 18:36:30 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/418#discussion_r60111097
  
    --- Diff: core/sqf/sqenvcom.sh ---
    @@ -505,23 +505,6 @@ EOF
       APACHE_HIVE_HOME=$HIVE_HOME
       export HIVE_CNF_DIR=$HIVE_HOME/conf
     
    --- End diff --
    
    Agree. It is good to remove this code, it proved not to be useful. I had the idea at some
time to figure out the install directories for Hadoop, HBase etc. by examining the CLASSPATH,
but that method caused more trouble than good. (in part because of the use of symbolic links,
I think).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message