trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <>
Subject [GitHub] incubator-trafodion pull request: Support for [TRAFODION-1891] and...
Date Tue, 19 Apr 2016 22:42:48 GMT
Github user DaveBirdsall commented on a diff in the pull request:
    --- Diff: core/sql/cli/Cli.cpp ---
    @@ -10495,13 +10528,18 @@ Lng32 SQLCLI_LOB_GC_Interface
           // Restore original data file.
           Int32 rc2=ExpLOBoper::restoreLobDataFile(lobGlobals,tgtLobName, (void *)currContext.exHeap(),hdfsServer,hdfsPort,lobLocation);
    +      if (rc2)
    +        {
    +          lobDebugInfo("restoreLobDataFile Failed",0,__LINE__,lobTrace);
    --- End diff --
    Is the value of rc2 interesting here? (Or is it always -1 on an error and therefore uninteresting?)

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message