trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kevinxu021 <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-533]Fixes for regress...
Date Thu, 28 Apr 2016 08:29:57 GMT
Github user kevinxu021 commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/452#discussion_r61390638
  
    --- Diff: core/conn/jdbc_type2/native/SqlInterface.cpp ---
    @@ -2570,12 +2570,9 @@ SQLRETURN ALLOCSQLMXHDLS_SPJRS(SRVR_STMT_HDL *pSrvrStmt, SQLSTMT_ID
*callpStmt,
     	if (pModule->module_name == NULL)
     	{
     		DEBUG_OUT(DEBUG_LEVEL_STMT,("***pModule->module_name == NULL  Call AllocStmtForRs()"));
    -/* Commenting out for now - will be looked at when SPJ is supported
    - #ifdef NSK_PLATFORM
     		CLI_AllocStmtForRS(callpStmt,
    --- End diff --
    
    @selvaganesang For spj tests, a spj jar package is required while create a library. I'm
not sure the path of the JAR. it seems to be a little complicated. The JAR should be existing
on server-side(every node). i'm not sure the IP address/host name(where to upload) while the
tests running.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message