trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandhyasun <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Fix for [Trafodion-1941] and par...
Date Wed, 27 Apr 2016 21:41:26 GMT
GitHub user sandhyasun opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/453

    Fix for [Trafodion-1941] and partial change related to [TRAFODION-1943]

    Fix for Trafodion-1941 to allow syntax for specifying length for blob/clob columns.
    modified:  
    
       ../../../sql/exp/ExpLOB.cpp
       ../../../sql/exp/ExpLOB.h
       ../../../sql/exp/ExpLOBinterface.cpp
       ../../../sql/generator/GenItemFunc.cpp
       ../../../sql/generator/GenPreCode.cpp
      ../../../sql/optimizer/ImplRule.cpp
       ../../../sql/parser/sqlparser.y
      ../../../sql/regress/executor/EXPECTED130
      ../../../sql/regress/executor/FILTER130
       ../../../sql/regress/executor/TEST130
    
     Involves syntax changes and new runtime checks and a new testcase in executor/TEST130.clob
columns.iInvolves syntax changees and ene runtime checks and a new testcase in executor/TEST130.
    
    Error handling fix related to JIRA TRAFODION-1943. 
    	modified:   ../../../sql/sqlcomp/CmpSeabaseDDLschema.cpp
    	modified:   ../../../sql/sqlcomp/CmpSeabaseDDLtable.cpp
    The drop schema code will now exit as soon as there is an error and not continue executing.
Also fixed a problem in drop schema code where "if exists" was not specified correctly leading
to syntax errors.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sandhyasun/incubator-trafodion lob_get_trace

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/453.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #453
    
----
commit 2ce2d0d23b950e46c096719bf186200218333591
Author: Sandhya Sundaresan <sandhya@apache.org>
Date:   2016-04-27T21:31:37Z

    Fix for Trafodion-1941 to allow syntax for secifying length for blob/clob columns.iInvolves
syntax changees and ene runtime checks and a new testcase in executor/TEST130.
    
    Error handling fix related to JIRA TRAFODION-1943. The drop schema code will now exit
as soon as there is an error and not continue executing.ALso fixed a problem in drop schema
code where "if exists" was not specified correctly leading to syntax errors.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message