trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anoopsharma00 <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1920] suppress SQL er...
Date Mon, 02 May 2016 04:44:10 GMT
Github user anoopsharma00 commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/441#discussion_r61702049
  
    --- Diff: core/sql/exp/exp_eval.cpp ---
    @@ -862,7 +862,17 @@ ex_expr::exp_return_type ex_expr::evalClauses(ex_clause *clause,
     	atp1->setDiagsArea(diagsArea);
     
           if (retcode == ex_expr::EXPR_ERROR)
    -	return retcode;
    +      {
    +        if((getPCodeMode() & ex_expr::ERROR_CONTINUE) > 0)
    +        {
    +          ExpTupleDesc::setNullValue( op_data[0],
    +                                      clause->getOperand(0)->getNullBitIndex(),
    +                                      clause->getOperand(0)->getTupleFormat() );
    +          retcode = ex_expr::EXPR_OK;
    --- End diff --
    
    Couple things:
    Codegen time: The flag to move null in case of an error should be set only if target is
nullable.
    Runtime: Expr code should check to make sure that target is nullable before moving
    the null value. If target is non-nullable, then original error should be returned.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message