trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1971] Avoid redundant...
Date Fri, 13 May 2016 14:17:37 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/480#discussion_r63189803
  
    --- Diff: core/sql/executor/ExHbaseIUD.cpp ---
    @@ -1285,7 +1285,6 @@ ExWorkProcRetcode ExHbaseAccessBulkLoadPrepSQTcb::work()
           matches_ = 0;
           currRowNum_ = 0;
           numRetries_ = 0;
    -      hFileParamsInitialized_ = FALSE;
    --- End diff --
    
    Is this parameter used to create sampling of the loaded data. If so, can you please consider
using another condition too.
    
    Also, this flag is being reset to false in ALL_DONE/DONE step. So, commenting out in NOT_STARTED
step alone wouldn't help.
    
    I also see this comment in the constructor. Do you think should we retain this comment
still.
    
     hFileParamsInitialized_ = false;  ////temporary-- need better mechanism later



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message