trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From blfritch-esgyn <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1971] Avoid redundant...
Date Fri, 13 May 2016 18:53:04 GMT
Github user blfritch-esgyn commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/480#discussion_r63233699
  
    --- Diff: core/sql/executor/ExHbaseIUD.cpp ---
    @@ -1285,7 +1285,6 @@ ExWorkProcRetcode ExHbaseAccessBulkLoadPrepSQTcb::work()
           matches_ = 0;
           currRowNum_ = 0;
           numRetries_ = 0;
    -      hFileParamsInitialized_ = FALSE;
    --- End diff --
    
    I'm not sure what you mean by adding another condition. Sampling is controlled by a syntax
option of bulk load.
    
    Resetting the flag for ALL_DONE is not a problem because it is only executed when the
load (preparation phase) is done.  On the other hand, removing the one in NOT_STARTED, which
is executed after each flush, improved load time for a wide, 52M-row table from 3.5 hours
to 35-40 minutes (without Suresh's fix that changed flush frequency).
    
    I'm not sure why Khaled thought a better mechanism was needed. I would be fine with removing
the comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message