trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertamarton <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #523: TRAFODION [2025] Initialize authoriza...
Date Tue, 07 Jun 2016 14:47:53 GMT
Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/523#discussion_r66085087
  
    --- Diff: core/sql/cli/Context.cpp ---
    @@ -3850,6 +3856,48 @@ void ContextCli::createMxcmpSession()
       mxcmpSessionInUse_ = TRUE;
     }
     
    +// ----------------------------------------------------------------------------
    +// Method:  updateMxcmpSession
    +//
    +// Updates security attributes in child arkcmp
    +//
    +// Returns: 0 = succeeded; -1 = failed
    +// ----------------------------------------------------------------------------
    +Int32 ContextCli::updateMxcmpSession()
    +{
    +  // If no child arkcmp, just return
    +  if (getArkcmp()->getServer() == NULL)
    +    return 0;
    +
    +  // Send changed user information to arkcmp process
    +  CmpContext *cmpCntxt = CmpCommon::context();
    +  ex_assert(cmpCntxt, "No compiler context exists");
    +  NABoolean authOn = cmpCntxt->isAuthorizationEnabled();
    +
    +  // The message contains the following:
    +  //   (auth state and user ID are delimited by commas)
    +  //     authorization state (0 - off, 1 - on)
    +  //     integer user ID
    +  //     database user name
    +  // See CmpStatement::process (CmpMessageDatabaseUser) for more details
    +  Int32 userAsInt = (Int32) databaseUserID_;
    +  char userMessage [MAX_AUTHID_AS_STRING_LEN + 1 + MAX_USERNAME_LEN + 1 + 2];
    +  str_sprintf(userMessage, "%d,%d,%s", authOn, userAsInt, databaseUserName_);
    +  char *pMessage = (char *)&userMessage;
    +
    +  // Send message to child arkcmp, if one exists
    +  ExSqlComp::ReturnStatus cmpStatus;
    +  ExSqlComp *exSqlComp = getArkcmp();
    +  ex_assert(exSqlComp, "CliGlobals::getArkcmp() returned NULL");
    +  cmpStatus = exSqlComp->sendRequest(EXSQLCOMP::DATABASE_USER,
    +                     (const char *) pMessage,
    +                     (ULng32) strlen(pMessage));
    +  if (cmpStatus == ExSqlComp::ERROR)
    +    return -1;
    +
    +  return 0;
    +}
    +
    --- End diff --
    
    The code does propagate the change through the child, grandchild, etc. For drop authorization
there are 4 generations of arkcmps and I need to propagate this value through them all - there
is actually are regression test for this - udr/102.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message