trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertamarton <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #544: [TRAFODION-2044] Support SALT clause ...
Date Mon, 13 Jun 2016 21:10:15 GMT
Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/544#discussion_r66868775
  
    --- Diff: core/sql/parser/sqlparser.y ---
    @@ -24909,7 +24946,6 @@ create_table_as_token: TOK_AS
     
     /* type pElemDDL */
     table_definition_body : table_element_list
    -                      | like_definition
                           | external_table_definition
     
    --- End diff --
    
    It looks like the new like option is no longer part of a table_definition_body but as
a separate high-level production.  Would this break some operations?  For example, I see on
line 24594 that a "like" option is syntactically correct with <special_table_name> option.
 Would this still be allowed with your change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message