trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traflm <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #542: [TRAFODION-2046]change DTM's memoryUs...
Date Tue, 14 Jun 2016 00:15:46 GMT
Github user traflm commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/542#discussion_r66891200
  
    --- Diff: core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/coprocessor/transactional/TrxRegionEndpoint.java.tmpl
---
    @@ -359,7 +359,7 @@ CoprocessorService, Coprocessor {
       private static final int DEFAULT_SLEEP = 60 * 1000;
       private static final int DEFAULT_MEMORY_THRESHOLD = 100; // 100% memory used
    --- End diff --
    
    In checkMemoryUsage(), it will check the current memory usage with this DEFAULT_MEMORY_THRESHOLD,
if I change the DEFAULT_MEMORY_THRESHOLD, that logic will break. Here the change only change
the startup value. The name of DEFAULT_MEMORY_THRESHOLD is confusing, it is not only setting
a default value, but also setting a low watermark , so I cannot simply change that value.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message